166 likes
·
3.0K reads
19 comments
That is an awesome article Curtis Einsmann, you made some really good points
And congrats on getting your first article featured on hashnode :)
Thanks Apoorv! Appreciate the kind words.
Nice one,
So when you approve with comments do you get a lot of people who actually go and fix them anyway?
I tend to do this, just to learn from the reviewer, was wondering if many people do that.
Depends on the developer.
When my teammates approve my authored PR's with comments, I always address them before a merge. But I don't hold a grudge against my teammates if they don't do the same.
Hey, nice article!
Also, happy to see you here. :-)
Thanks Catalin! Good to see you here, too. =)
Excellent read. I'd be interested to hear how unit tests play into your review process, if at all.
Thank you Braydon! Unit tests are included within the PR in most cases. Same principles apply for the most part. Sometimes the author can indicate what the test coverage is.
Curtis Einsmann Awesome - thanks for replying!
Great article Curtis!
You make some great points.
I specially liked the ones about encouraging a high code quality bar and design principles being guidelines, not rules.
Thanks Mario! Yes, it's important to keep this in mind. We must acknowledge that subjectivity that comes with code preferences.
Awesome Article Curtis Einsmann!
I liked the way you measure PR's with kindness...!
Thanks, Jay! That's the most important point here. 😄
This was a great article. Thank you for sharing your experience. Bookmarked !!
Absolutely. Happy you liked it!
Amazing and insightful article.
Thanks for reading!
A very good article about the PR review.
Thanks for reading, Kiran!